-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RN] Add an option for staging the React via AppHub #1817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@orta, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ashfurrow to be a potential reviewer |
Generated by 🚫 danger |
orta
changed the title
[WIP][RN] Add an option for staging the React via AppHub
[RN] Add an option for staging the React via AppHub
Sep 9, 2016
Impressive 👏 Let me know when this good to go! |
This was referenced Sep 14, 2016
OK, this is good to go |
Sahweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an admin panel that defaults to off
Toggling it adds:
Which offers a way to see:
This links to
:head
, which can mean that the Eigen Obj-C Emission can be out of date with what Emission expects to be exposed to the JS. E.g. the module providers here:head
eigen
Do I have any long term answers, not really, I mean we did do a minor patch for this, so it does make sense. I've noted in slack that maybe an answer is to have deploys of Emission that are only the obj-c and to keep the same JS shipped with it, and have that run on eigen.
It's hard to say whether we'd expect a lot of change over the bridging there.
Opening any container
I've got Eigen grabbing the list of exposed containers in the app registry, and puts those as clickable buttons. Then you can input any initial JSON state you want,
which will push you through into that view controller
this should make it much easier for beta testers to try out views before they're shipped into our
ARSwitchboard
.TODO:
AppHub
dependency needs to check for what subspecs it needs, currently it drags in the rest of React Native, which isn't optimal. PR sent Use React/Core for the podspec dependency AppHubPlatform/apphub#32ARAppDelegate+Emission.m
Other than that, this is all you need to run the master commit for artsy/Emission inside eigen