Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebView] Fixes video embedded in articles not playing inline on iOS 10. #1914

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Oct 12, 2016

@ArtsyOpenSource
Copy link
Contributor

1 Warning
⚠️ Detected some Swift building time outliers
Time Class Function
203.8ms SwiftyJSON.swift get {}
161.8ms WebSocket.swift private func processRawMessage(buffer: UnsafePointer, bufferLen: Int)
91.2ms LiveAuctionLotViewController.swift @objc override func viewDidLoad()
80.1ms Observable.swift private final func nextTokenHash() -> Int
74.0ms AuctionLotMetadataStackScrollView.swift required init(viewModel: LiveAuctionLotViewModelType, salesPerson: LiveAuctionsSalesPersonType, sideMargin: String)
71.6ms LiveAuctionsAdminViewController.swift @objc override func viewDidLoad()
69.4ms UIViewController+BlurredStatusView.swift func ar_presentBlurredOverlayWithTitle(title: String, subtitle: String, buttonState: BlurredStatusOverlayViewCloseButtonState = default)
67.3ms UIViewController+BlurredStatusView.swift (closure)

Generated by 🚫 danger

@orta
Copy link
Contributor

orta commented Oct 12, 2016

Looks good to me 👍

@orta orta merged commit 0fb1d42 into v3 Oct 12, 2016
@orta orta deleted the fix-webview-inline-video-playback branch October 12, 2016 16:23
ashfurrow pushed a commit that referenced this pull request Feb 20, 2020
ME-18 Send graphql request metrics to datadog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants