[MX-111] - Update Sentry #3037
Merged
[MX-111] - Update Sentry #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ds300
approved these changes
Feb 26, 2020
Comment on lines
+140
to
+143
| Sentry.withScope(scope => { | ||
| scope.setExtra("slug", this.props.artworkAboveTheFold.slug) | ||
| Sentry.captureMessage("failed to refresh artwork") | ||
| }) |
There was a problem hiding this comment.
[no action required] ooh, interesting, this Hub/Scope abstraction seems really useful. For future work it might be useful for us to provide a scoped hub for each page 🤔 I'll add a ticket to the backlog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally ready for review! Thanks for the help!
https://artsyproduct.atlassian.net/browse/MX-111
Here is an event with native breadcrumbs interleaved with javascript after the patch:
https://sentry.io/organizations/artsynet/issues/1493286938/events/d142f9410a5b4bda9447a8e45471d7f0/?project=166818
Here is a native crash showing only native breadcrumbs:
https://sentry.io/organizations/artsynet/issues/1531708186/?project=166818&query=&statsPeriod=14d
Co-authored with @ashfurrow @ds300