[FX-1735] Featured artist view #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtina-starr
force-pushed
the
featured-artist-view
branch
from
a39e389
to
4ae35a0
Compare
sweir27
reviewed
Feb 25, 2020
| }} | ||
| > | ||
| <ViewAll size="4">View all</ViewAll> | ||
| {/* <Box> |
There was a problem hiding this comment.
Can we remove the commented-out bit?
3 tasks
sweir27
reviewed
Feb 25, 2020
| import { CollectionFeaturedArtistsContainer as CollectionFeaturedArtists } from "../FullFeaturedArtistList" | ||
| jest.unmock("react-relay") | ||
|
|
||
| describe("FullFeaturedArtistList", () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: FX-1735
Issue:
When there are several featured artists within a collection and a user clicks the "View more" link, the featured artist module pushes the content beneath the featured artist module down making it not visible to the user.
Fix:
This PR refactors the featured artist component to take the user to a new view when the "View all" link is clicked. This displays all the artists that are within the collection and gives the user a back button to navigate back to the collection.