-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewing rooms visual cleanup #3232
Conversation
6bbbe8c
to
45eda72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I had a couple of suggestions but feel free to merge after addressing those
const totalCount = props.viewingRoomArtworks.artworks! /* STRICTNESS_MIGRATION */ | ||
.totalCount! /* STRICTNESS_MIGRATION */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a follow-up it would be good to make these non-nullable in MP!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good thought! added to my to-do list
Co-authored-by: David Sheldrick <d.j.sheldrick@gmail.com> Co-authored-by: Adam Iskounen <adam.iskounen@artsymail.com>
Co-authored-by: David Sheldrick <d.j.sheldrick@gmail.com>
57df02a
to
c2bf5ee
Compare
Still a few things to go here, but it's a start!
cc @iskounen @ds300 I'll work on wrapping this + #3215 tomorrow!
Here's the list I'm working off of:
Header image extends into the horns(leaving this for a followup PR that focuses on a few header tweaks)#trivial