Viewing rooms visual cleanup #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdole
force-pushed
the
viewing-rooms-visual-cleanup
branch
2 times, most recently
from
6bbbe8c
to
45eda72
Compare
mdole
changed the title
mdole
commented
Apr 28, 2020
ds300
approved these changes
Apr 28, 2020
Comment on lines
+24
to
+25
| const totalCount = props.viewingRoomArtworks.artworks! /* STRICTNESS_MIGRATION */ | ||
| .totalCount! /* STRICTNESS_MIGRATION */ |
There was a problem hiding this comment.
as a follow-up it would be good to make these non-nullable in MP!
There was a problem hiding this comment.
good thought! added to my to-do list
Co-authored-by: David Sheldrick <d.j.sheldrick@gmail.com> Co-authored-by: Adam Iskounen <adam.iskounen@artsymail.com>
Co-authored-by: David Sheldrick <d.j.sheldrick@gmail.com>
mdole
force-pushed
the
viewing-rooms-visual-cleanup
branch
from
57df02a
to
c2bf5ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a few things to go here, but it's a start!
cc @iskounen @ds300 I'll work on wrapping this + #3215 tomorrow!
Here's the list I'm working off of:
Header image extends into the horns(leaving this for a followup PR that focuses on a few header tweaks)#trivial