Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: match artwork filter feature flag name to project name #4522

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

iskounen
Copy link
Contributor

@iskounen iskounen commented Mar 12, 2021

The type of this PR is: Refactor

This PR resolves FX-2719

Description

I originally named the feature flag for the ongoing artwork filter work ARUseNewArtworkFilters in #4515. Upon reflection I would like to rename this to be ARUseImprovedArtworkFilters because:

  1. That is the name of the JIRA epic and project brief for this work, and
  2. The new artwork filters won't be new forever

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

@iskounen iskounen marked this pull request as draft March 12, 2021 20:58
@iskounen
Copy link
Contributor Author

This is a draft until #4507 is merged and I get a chance to include changes to that code in this PR.

@iskounen iskounen self-assigned this Mar 12, 2021
@artsy artsy deleted a comment from artsy-peril bot Mar 12, 2021
@iskounen iskounen requested a review from dblandin March 15, 2021 16:16
@iskounen iskounen assigned dblandin and dzucconi and unassigned dblandin and iskounen Mar 15, 2021
@iskounen iskounen force-pushed the iskounen/rename-artwork-filter-feature-flag branch from 82115c1 to e6f3ad8 Compare March 15, 2021 17:10
@iskounen iskounen marked this pull request as ready for review March 15, 2021 17:11
@iskounen iskounen force-pushed the iskounen/rename-artwork-filter-feature-flag branch from e6f3ad8 to edb04cc Compare March 15, 2021 17:14
@iskounen iskounen merged commit 43c4080 into master Mar 15, 2021
@iskounen iskounen deleted the iskounen/rename-artwork-filter-feature-flag branch March 15, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants