chore(CX-1790): Add skeleton loader on Auction results by artists you follow #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 31, 2021 11:41
- Pass a skeleton component to renderWithPlaceholder - Extract ListHeader to a component to reuse inside the skeleton component
…rArtistsYouFollow
MounirDhahri
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Congrats on your first Eigen contribution 🎉 This is looking great and is clear to go.
The only comment I have is about updating the changelog section to include your changes. You can read more about it in this RFC
Updated! 🚀 |
MounirDhahri
deleted the
lean8086/skeleton-auction-for-artists-you-follow
branch
Gon4ar5
pushed a commit
that referenced
this pull request
Oct 27, 2021
… follow (#5366) * feat: Add skeleton component to AuctionResultsForYou - Pass a skeleton component to renderWithPlaceholder - Extract ListHeader to a component to reuse inside the skeleton component * chore: Change component name AuctionResultsForYou to AuctionResultsForArtistsYouFollow * chore: Adjust skeleton elements to include price and mid estimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: chore
This PR resolves CX-1790
Description
Adds a skeleton loader for the Auction results by artists you follow screen.
Changes the name of the component from AuctionResultsForYou to AuctionResultsForArtistsYouFollow.
iOS
iPad
PR Checklist (tick all before merging)
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes