@alloy => Convert back to static libs #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seeing as you cleaned out the issues. I added some new ones for you.
|
|
Great, thanks! Can you fix the warnings so I can merge it? |
|
Be glad I like you, that's an interns job. Done. |
|
Delivering PRs without warnings, though… 😝 |
|
Based on the |
|
ah yeah, tests |
|
I think circle just went down, but I pushed a commit for the the four |
|
Thanks! |
alloy
added a commit
that referenced
this pull request
Oct 1, 2015
@alloy => Convert back to static libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #586
So far, I've only converted app-code. This runs 👍 - we have no actual need for using frameworks yet other than keeping up-to-date. So they are definitely not worth the current launch time.