[Feature] Add ability to watch modules #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
force-pushed
the
feature-watch-multiple-paths
branch
2 times, most recently
from
62e03fb
to
b66cadb
Compare
damassi
force-pushed
the
feature-watch-multiple-paths
branch
from
b66cadb
to
b3da32b
Compare
|
Changes seem nice and simple 👍 |
craigspaeth
reviewed
Nov 9, 2017
| // Or if you're using `yarn link` (or npm) to symlink external dependencies | ||
| // during dev, pass in an array of modules to watch. Changes made internally | ||
| // will be instantly available in the app. | ||
| watchModules: [ |
There was a problem hiding this comment.
Is this config necessary? Could this module watch all node modules/symlinks by default or would that be too much?
There was a problem hiding this comment.
@craigspaeth - opt-in is necessary as watching the whole folder would be extremely slow :)
|
Awesome! Excited to have this help the Reaction <> Force disparity! 👏 Left a small question, but code LGTM—feel free to merge at will. |
This was referenced Nov 9, 2017
|
🚀 PR was released in v1.4.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional watching ability, making it easy to listen for changes in
node_modulesand automatically reload dependencies on request. This is useful when working across library boundaries whereyarn linkis often used to symlink NPM deps during development.Closes #2