Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galleries A-Z list not sorted properly #2085

Open
starsirius opened this issue Jan 17, 2018 · 3 comments
Open

Galleries A-Z list not sorted properly #2085

starsirius opened this issue Jan 17, 2018 · 3 comments
Labels

Comments

@starsirius
Copy link
Member

Reported in Slack.

The galleries A-Z page is supposed to sort the partners in alphabetical order with sortable_id. However, the order in each section isn't actually guaranteed and I think it depends on the order of completion of parallel requests that fetch all partners.

@starsirius starsirius added the Bug label Jan 17, 2018
@sooogi
Copy link

sooogi commented Jan 27, 2018

hey @starsirius,
I'm trying to get the list of partners, but I don't have access to the API URL. Currently, I'm receiving four pieces of data (in the screenshot), but it's not the same data I'm seeing on the production version on artsy.net. I understand that it's supposed to hit https://stagingapi.artsy.net/api/v1/partners, but I get an "Unauthorized" user error. I've tried using the ARTSY_ID/CLIENT_ID and the ARTSY_SECRET/CLIENT_SECRET values from env, but neither worked. Any tips?
screen shot 2018-01-27 at 5 51 42 pm

@starsirius
Copy link
Member Author

starsirius commented Jan 29, 2018

@ckong1792 Welcome to Force and thanks for contributing!

There was a data issue in our staging server. I've re-indexed the partners and you should be able to see the full list of partners on that page.

Re authentication on stagingapi.artsy.net, you can find more doc on developers.artsy.net. For this specific API call, you can follow the 2 steps to authenticate with an XAPP token.

  1. Get an XAPP token with the CLIENT_ID and CLIENT_SECRET (in code). For example,

    https://stagingapi.artsy.net/api/v1/xapp_token?client_id=<CLIENT_ID>&client_secret=<CLIENT_SECRET>
    
  2. Fetch partners with the XAPP token (in code). For example,

    https://stagingapi.artsy.net/api/v1/partners?xapp_token=<XAPP_TOKEN>
    

And the partners endpoint accepts params to filter the result.

Let me know if I can help clarify anything!

@madeleineb
Copy link

cc: @jordanchart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants