Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log debug statements around git operations, for easier debugging #471

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

joeyAghion
Copy link
Collaborator

After last week's many branch renames, I checked on Horizon's cron and saw messages like this indicating that several projects' configurations were broken:

fatal: ambiguous argument '369fbf0245b91941b7685b69c937fb37d1b8243a..main/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [...] -- [...]'
fatal: ambiguous argument 'f588c0f4cfb410faf3e028a46f759c20fb3d3a36..main/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [...] -- [...]'
fatal: ambiguous argument 'ee99b953b67e9a4caadeaa39a03062e9d8312384..main/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [...] -- [...]'
fatal: ambiguous argument '04a9f7fd503267c99e8788a4733b189f6bf7113f..main/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [...] -- [...]'

However, I couldn't easily tell which projects were responsible for the errors. This PR adds debug-level log statements around each project refreshed by the recurring cron. By setting the LOG_LEVEL=0 environment variable, we should be able to more easily diagnose issues based on cron logs in the future. (I recommend unsetting it afterwards.)

@sonecabr sonecabr merged commit 5b7d466 into main Dec 13, 2021
@sonecabr sonecabr deleted the joeyAghion/dev branch December 13, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants