@damassi => Add semantic-release #521

eessex · 2018-02-14T18:52:13Z

Adds semantic-release package
Adds custom commit message releaseRules to package.json in the Ember standard
Runs semantic-release after tests pass on master branch
Updates readme to include explanation and examples for commit formats.

GH_TOKEN has also been added to reaction on Circle CI (npm token was already present)

damassi · 2018-02-14T20:41:06Z

circle.yml

@@ -27,6 +27,9 @@ test:
    - yarn test -- --runInBand

 deployment:
+  release:
+    branch: master
+      - yarn run semantic-release


I think there is some legacy stuff around here that relates to legacy deployment process. Once we've verified that this works we should make sure to remove that and update README.

damassi · 2018-02-14T21:21:12Z

Talked with @eessex and we're going to setup a test repo to give the process a spin and figure out what we need and then come back here.

…ions

eessex · 2018-02-16T15:24:44Z

After merging conflicts, 17K lines were added to this PR -- any idea where these came from?

orta · 2018-02-16T15:26:24Z

It looks like they came from the #522 change - I think you git add .'d all the old files, run find . -name __generated__ | xargs rm -rf, them yarn relay and then amend your commit 👍

damassi · 2018-02-16T18:17:18Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "@artsy/reaction-force",
-  "version": "0.23.1",
+  "version": "0.0.0-development",


Will this account for existing packages that have already been published to NPM? Does it determine from there that the current release is 0.23.1 and update accordingly?

Yes, it should fetch the version number from the existing package on npm. This version number is a placeholder and will always read 0.0.0.

When merging, the build on Circle will log which commits trigger changes, as well as the new version number.

Sweet, just wanted to double check 👍

Also wanted to note it looks like this version number is being overwritten when I push a commit, but don't see where this is being set.

damassi · 2018-02-16T18:17:43Z

package.json

+        {"tag": "FEATURE", "release": "minor"},
+        {"tag": "BREAKING", "release": "major"}
+      ]
+    }


damassi · 2018-02-16T18:19:22Z

README.md

+```
+
+[Valid tags](https://github.com/artsy/reaction/blob/master/package.json#L175) for release include DOC, FIX (patch), FEATURE (minor), and BREAKING (major). Commits that do not adhere to this convention will not trigger an NPM release.
+


What do you think about FIX vs PATCH as being the primary trigger? I always associate FIX with "BUGFIX" rathar than a minor change.

Open to either, we can also add both or additional tags.

Yeah, lets go ahead and associate PATCH and FIX with a minor release

damassi · 2018-02-16T18:26:38Z

README.md

+##### Example Patch Release
+```
+[FIX onboarding]: increase plus-button size
+```


And update with additional example so that its clear:

[FIX onboarding] Modal does not open [PATCH] Bump version

Also, can you remove the : from the docs so that its clear that this syntax is not required?

damassi · 2018-02-16T18:36:21Z

This looks good to me -- @orta / @alloy, thoughts? Otherwise 👍

orta · 2018-02-16T18:39:43Z

Have a think if there's a peril rule that could remind you about adding [FIX] or [PATCH] to commits

damassi · 2018-02-16T18:57:23Z

@orta - what I'm thinking is that those should only be added when a release is desired, though @eessex and I went back and forth about whether every commit should be a release. I'm in the camp that for a project like Reaction it should be targeted and selective. For example, there could be many commits in a PR that has nothing to do with a release, or there could be many commits and then the last one is tagged signalling a release, or the whole thing could be squashed into one commit with a tag. But I think it should be conventional rather than required. Thoughts? Maybe a danger warning? But even then, i think having our README up to date in terms of how to release is sufficient -- a git commit --allow-empty -m '[PATCH] would be enough.

alloy · 2018-02-16T20:58:48Z

I like it 👍

I like that you still need to trigger a release, the future will tell us wether or not people in practice run into issues with that.

damassi · 2018-02-16T21:01:28Z

Alright, gonna merge. Thanks for diving into this new area @eessex, will def help keep things efficient 👍

orta · 2018-02-16T22:24:03Z

Yeah, I like the idea 👍

orta · 2018-02-16T22:24:26Z

i think it's simple enough to not need a danger/peril rule

add semantic release package, add deploy script to circle yml

0444c11

eessex requested a review from damassi February 14, 2018 18:52

damassi reviewed Feb 14, 2018

View reviewed changes

remove npm ci scripts

6cb2b8d

eessex added 3 commits February 15, 2018 11:29

update readme

954ec94

add release rules based on ember standard

c6fc1a1

[DOC semantic-release] update docs to reflect ember changelog convent…

44e6fa9

…ions

merge conflicts

820c1b9

eessex force-pushed the semantic-release branch from 4dcfa14 to 820c1b9 Compare February 16, 2018 18:12

eessex changed the title ~~[WIP] Add semantic-release~~ @damassi => Add semantic-release Feb 16, 2018

damassi reviewed Feb 16, 2018

View reviewed changes

package.json Outdated

{"tag": "FEATURE", "release": "minor"},

{"tag": "BREAKING", "release": "major"}

]

}

Copy link

Member

damassi Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

damassi reviewed Feb 16, 2018

View reviewed changes

add patch tag, update readme

f0056e0

eessex force-pushed the semantic-release branch from 89fb37c to f0056e0 Compare February 16, 2018 18:33

Merge branch 'master' into semantic-release

ca470de

damassi merged commit 01910a9 into artsy:master Feb 16, 2018

orta mentioned this pull request Feb 21, 2018

@damassi => Rename NPM package 'Reaction' #540

Closed

damassi mentioned this pull request Jan 4, 2019

Move to continuous deployment #388

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@damassi => Add semantic-release #521

@damassi => Add semantic-release #521

eessex commented Feb 14, 2018 •

edited

Loading

damassi Feb 14, 2018

eessex Feb 14, 2018

damassi commented Feb 14, 2018

eessex commented Feb 16, 2018 •

edited

Loading

orta commented Feb 16, 2018 •

edited

Loading

damassi Feb 16, 2018 •

edited

Loading

eessex Feb 16, 2018 •

edited

Loading

eessex Feb 16, 2018 •

edited

Loading

damassi Feb 16, 2018

eessex Feb 16, 2018

damassi Feb 16, 2018

damassi Feb 16, 2018

eessex Feb 16, 2018

damassi Feb 16, 2018

damassi Feb 16, 2018

damassi Feb 16, 2018

damassi commented Feb 16, 2018

orta commented Feb 16, 2018

damassi commented Feb 16, 2018

alloy commented Feb 16, 2018

damassi commented Feb 16, 2018

orta commented Feb 16, 2018

orta commented Feb 16, 2018

		```

		[Valid tags](https://github.com/artsy/reaction/blob/master/package.json#L175) for release include DOC, FIX (patch), FEATURE (minor), and BREAKING (major). Commits that do not adhere to this convention will not trigger an NPM release.

@damassi => Add semantic-release #521

@damassi => Add semantic-release #521

Conversation

eessex commented Feb 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damassi commented Feb 14, 2018

eessex commented Feb 16, 2018 • edited Loading

orta commented Feb 16, 2018 • edited Loading

damassi Feb 16, 2018 • edited Loading

Choose a reason for hiding this comment

eessex Feb 16, 2018 • edited Loading

Choose a reason for hiding this comment

eessex Feb 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damassi commented Feb 16, 2018

orta commented Feb 16, 2018

damassi commented Feb 16, 2018

alloy commented Feb 16, 2018

damassi commented Feb 16, 2018

orta commented Feb 16, 2018

orta commented Feb 16, 2018

eessex commented Feb 14, 2018 •

edited

Loading

eessex commented Feb 16, 2018 •

edited

Loading

orta commented Feb 16, 2018 •

edited

Loading

damassi Feb 16, 2018 •

edited

Loading

eessex Feb 16, 2018 •

edited

Loading

eessex Feb 16, 2018 •

edited

Loading