Implement hyphens in data-bind attributes and optional '=' #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added extra hyphen test when using one Object in constructor;
| }, '<div><span data-bind="first, name name, firstColor firstColor"/>' + | ||
| '<span data-bind="last, name name, lastColor lastColor"/></div>'); | ||
| 'last-color': 'Blue' | ||
| }, '<div><span data-bind="first, name=name, firstColor=firstColor"/>' + |
There was a problem hiding this comment.
Does it also work with arbitrary spaces around the equal sign, like:
data-bind="first, name = name, firstColor = firstColor"
?
There was a problem hiding this comment.
OK just tested this and it does work :)
|
Awesome, thanks Tristan! Maybe in the near future we can deprecate using spaces in favor of equal signs (I agree with @tlack that it is more readable). |
arturadib
added a commit
that referenced
this pull request
Dec 16, 2011
Implement hyphens in data-bind attributes and optional '='
arturadib
added a commit
that referenced
this pull request
Dec 16, 2011
|
@arturadib I agree on the deprecation of using spaces |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62 per @tlack 's suggestion
Helps prevent #55 per @tlack 's suggestion