Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix url concat in command(), update forum link #3

Merged
merged 1 commit into from
Jan 26, 2021
Merged

fix url concat in command(), update forum link #3

merged 1 commit into from
Jan 26, 2021

Conversation

Pack3tL0ss
Copy link
Contributor

base.py command() would result in an invalid url ...arubanetworks.comconfiguration/...
When called via update template. configuration.py update_template() uses urls.urlJoin which results in a
the url suffix with no leading "/"

The existing get_url method seemed like the best way to handle it.

commit also includes removal of trailing white-space
Update airheads forum url (forum backend recently changed)

@karthikeyan-dhandapani
Copy link
Member

Thanks @Pack3tL0ss for your contribution. Please submit to the development branch next time. I will update the contribution guidelines about submission to the development as well.

@karthikeyan-dhandapani karthikeyan-dhandapani merged commit 8f5262d into aruba:master Jan 26, 2021
@Pack3tL0ss
Copy link
Contributor Author

Thanks! I'll submit to dev next time. and yes this is Wade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants