-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hints #79
Merged
Merged
Type hints #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added mypy.ini config file for mypy
@tellezsanti Thanks for the PR! I just started to review it. A couple of quick issues I noticed before looking into the code.
I will continue to review the changes to code and request change if needed. |
* working on refactoring inheritance * update base * update base * cleaned up base update * turned on sync_params in init
tailaiw
approved these changes
Mar 5, 2020
@tellezsanti I made some (big) changes following your works (see updated PR description). If you have no problem, I'm gonna merge. |
Merged
tailaiw
added a commit
that referenced
this pull request
Mar 6, 2020
Merged
tailaiw
added a commit
that referenced
this pull request
Mar 6, 2020
* Added type hints to conf.py Added mypy.ini config file for mypy * type hints * type hints * mypy check * aggragtor fix * type hints * corrected type hints * clean up * clean up * undo unnecessary typing * Refactor inheritance structure (#83) * working on refactoring inheritance * update base * update base * cleaned up base update * turned on sync_params in init * deleted old base archive * removed Literal * a lot more work on typing * fixed type around pipe * more cleaning up * fixed all type hints in metrics * fixed a type * clean up * use set_params * comment out non-trainable multivariate detector * removed unnecessary lines * omit @Property and @overload * fixed type * allowed empty steps in pipenet * omit plot_flowchart in coverage * some more cleaning up * removed unnecessary * hide sub-modules to private * some docstring fix * a lot of cleaning work on docstrings * fixed a typo * loose callable type * added mypy to CI/CD * fixed docstring * updated version number * updated changelog Co-authored-by: tailaiw <tailai.wen@arundo.com> Co-authored-by: tailaiw <29800495+tailaiw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Added type hints, and added type checking in CI/CD test
Refactored the inheritance structure
We made all second-order sub-modules private and user now can only import from first-order modules, i.e.
Improved docstrings and API documentation
Fixed minor bugs and typos
Turned some parameters in some models required
window
inadtk.detector.LevelShiftAD
window
inadtk.detector.VolatilityShiftAD
window
inadtk.transformer.RollingAggregate
window
inadtk.transformer.DoubleRollingAggregate
model
inadtk.detector.MinClusterDetector
model
inadtk.detector.OutlierDetector
target
andregressor
inadtk.detector.RegressionAD
target
andregressor
inadtk.transformer.RegressionResidual
aggregate_func
inadtk.aggregator.CustomizedAggregator
detect_func
inadtk.detector.CustomizedDetector1D
detect_func
inadtk.detector.CustomizedDetectorHD
transform_func
inadtk.transformer.CustomizedTransformer1D
transform_func
inadtk.detector.CustomizedTransformer1D
steps
inadtk.pipe.Pipeline