Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lascheck report of invalid data index channel #3

Merged

Conversation

dcslagel
Copy link
Contributor

Description:

Reorder curve_df so that a valid Las2 index channel is the first data
column.

Running a dlis-to-las generated las file through lascheck reports an 'Invalid index
mnemonic'The only valid mnemonics for the index channel are DEPT, DEPTH,
TIME, or INDEX.’]. This is for Las 2.0 spec.

This may help other tools read the Dlis-to-Las las files.

To reproduce:

pip install lascheck
import lascheck
myfile = 'dlis-to-las.las'
print('-------------------------------------------')
las = lascheck.read(myfile)
print('-------------------------------------------')
print(myfile, las.check_conformity())
print('-------------------------------------------')
print(las.get_non_conformities())

Result

['Invalid index mnemonic. The only valid mnemonics for the index channel are DEPT, DEPTH, TIME, or INDEX.']

Test Results

All tests pass

Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.

Thank you,
DC

Reorder curve_df so that a valid Las2 index channel is the first data
column.
@aruss175 aruss175 self-assigned this Oct 1, 2020
@aruss175 aruss175 merged commit a20d419 into aruss175:master Oct 1, 2020
dcslagel added a commit to dcslagel/DLISIO_Notebooks that referenced this pull request Oct 13, 2020
This reverts commits
a20d419 Merge pull request aruss175#3 from
eecec92 Add test for new move_valid_index_to_first_col()
67dc925 Fix lascheck report of invalid data index channel
dcslagel added a commit to dcslagel/DLISIO_Notebooks that referenced this pull request Oct 13, 2020
This reverts commits
a20d419 Merge pull request aruss175#3 from
eecec92 Add test for new move_valid_index_to_first_col()
67dc925 Fix lascheck report of invalid data index channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants