Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request feature: Swarm Merging #4936

Closed
cocokola opened this issue Aug 3, 2020 · 28 comments
Closed

request feature: Swarm Merging #4936

cocokola opened this issue Aug 3, 2020 · 28 comments
Labels

Comments

@cocokola
Copy link

cocokola commented Aug 3, 2020

as per qbittorrent, they said to post the request for swarm merging to this development. see following paste:

Sometimes there are multiple torrents of the same data but the availability is low or incomplete and it would be nice to merge torrents.
In vuze the is something like swarm merging:
https://wiki.vuze.com/w/Swarm_Merging

It is possible to implement this too in qbittorrent?

Keep up the good work!

Please provide the following information

libtorrent version (or branch):

platform/architecture:

compiler and compiler version:

please describe what symptom you see, what you would expect to see instead and
how to reproduce it.

@arvidn
Copy link
Owner

arvidn commented Aug 3, 2020

previous ticket: #829

@xavier2k6
Copy link
Contributor

xavier2k6 commented Aug 5, 2020

@arvidn as a suggestion, perhaps labeling this as "enhancement"/"help wanted" & "pinning" it would garner more exposure from others who may be interested or indeed be in a position to make a "PR" to introduce this "feature request".

Also, another previous ticket: #3272

@stale
Copy link

stale bot commented Nov 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 3, 2020
@cocokola
Copy link
Author

cocokola commented Nov 4, 2020

guess that is one way to lower the workload ;) it would be nice to have IMHO, but not critical.

@allanlaal
Copy link

use case:

I read alot. like alot!
I use LazyLibrarian to constantly search for and download ebooks/abooks from my Goodreads' "To Read" list with Jackett from a massive list of public trackers. LazyLibrarian then queues them in a torrent client (currently qbittorrent)
I'd like the torrent client (qbittorrent) to be able to swarm merge those torrents as usually trackers might duplicate a torrent by adding their own "tracked by xxx" text files & other trash.
in addition most (like 80%) of book torrents have little to no seeds or if they are seeded, they are slooooooow af, so thats an obvious use case for swarm merge

@zero77
Copy link

zero77 commented Dec 9, 2020

@allanlaal
Completely agree but, I think swarm merging will be more feasible with the wider adoption of BitTorrent v2 and hybrid torrents.

https://blog.libtorrent.org/2020/09/bittorrent-v2
https://torrentfreak.com/libtorrent-adds-support-for-bittorrent-v2-a-potential-game-changer-200912

@stale
Copy link

stale bot commented Mar 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 9, 2021
@allanlaal
Copy link

unstaling

@stale stale bot removed the stale label Mar 9, 2021
@stale
Copy link

stale bot commented Jun 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 8, 2021
@allanlaal
Copy link

unstaling

@stale stale bot removed the stale label Jun 8, 2021
@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 6, 2021
@zero77
Copy link

zero77 commented Sep 8, 2021

Unresolved

@stale stale bot removed the stale label Sep 8, 2021
@stale
Copy link

stale bot commented Dec 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 8, 2021
@stale stale bot closed this as completed Dec 28, 2021
@TheBestPessimist
Copy link

TheBestPessimist commented Dec 29, 2021

Should not be closed imo.

Also, the stale bot not should have a tag "don't mark this as stalled", which will stop the "not stale" noise. That tag should be added to this issue and to others like it

@allanlaal
Copy link

allanlaal commented Apr 7, 2022

Lets STOP using stale bots!: #6797

@master255
Copy link

Your feature request is still open in my issue:
#6578

@master255
Copy link

@cocokola @allanlaal @TheBestPessimist I was able to teach libtorrent to load data from another torrent. I used https torrents for that. My free Android app Media Library (based on libtorrent 1.2.13) supports swarm merging. Enjoy!

@cocokola
Copy link
Author

cocokola commented May 1, 2022 via email

@allanlaal
Copy link

@arvidn could you reopen this issue - its kind of an important feature imho :D

@iopq
Copy link

iopq commented Aug 16, 2022

I would like this. I thought it wasn't going to be added because it is marked as closed, but now I see the stalebot closed it and "Closed" is not quite accurate

@arvidn
Copy link
Owner

arvidn commented Aug 16, 2022

the reason the swarm merging feature hasn't been implemented is not because this issue was inactive and closed by the stale bot. The reason it hasn't been implemented is because nobody has volunteered to do it.

@arvidn arvidn reopened this Aug 16, 2022
@stale stale bot closed this as completed Sep 28, 2022
@allanlaal
Copy link

unstale!

@arvidn kill all stale bots! ;)

we still care about this feature, but things of this complexity take time in OpenSource

@arvidn
Copy link
Owner

arvidn commented Oct 19, 2022

a ticket being stale and closed is not a sign of people not caring. It's a sign of work not being done. Keeping tickets open does not make it any more likely for work to be done.

@mpeter50
Copy link

a ticket being stale and closed is not a sign of people not caring. It's a sign of work not being done. Keeping tickets open does not make it any more likely for work to be done.

I quite disagree with that. People looking for what could they generally improve upon wont check closed issues, because that normally means that it has been resolved, superseeded by an other one, or dismissed.

By allowing the stale bot to close the issue, and not reopening it, you are dismissing this feature, and saying that "if no one is implementing it, surely it is unnecessary".

@arvidn
Copy link
Owner

arvidn commented Aug 25, 2023

I quite disagree with that. People looking for what could they generally improve upon wont check closed issues

I don't think those people exist. Contributors either have a feature they need or want for their project, or they have users requesting a feature, or they solicit feedback or requests from some group of people.

@iopq
Copy link

iopq commented Aug 25, 2023

The default in Github is open issues, so when you search and find nothing, it seems like nobody else wants it

@mpeter50
Copy link

I don't think those people exist. Contributors either have a feature they need or want for their project, or they have users requesting a feature,

You may be right, I don't actually know who are the contributors in this project.

or they solicit feedback or requests from some group of people

I think that includes the issue tracker of the project, though. Where else is it a better place to search for good new feature ideas? Suggestions are naturally appearing at that place.

Whatever is the chance that someone would start working on this feature by finding this issue, I think its significantly lower if the issue is closed. All the while the chance of users opening duplicates is higher. When I'm opening an issue, be it a feature request or a bug report at any repository, I only search in the (usually much fewer) open issues, and when it seems useful then also in the first page of closed issues, but I never go through all of those. In the case of this project, there are only 105 open issues, but 1900 closed ones. Rarely I did go through all of the closed issue search results, for example on the Gitea repo, but most often it took a hour or more to do that.

@master255
Copy link

I finished downloading a torrent from another torrent. It's been a while. Maybe this will help you somehow #6578 (comment)

And read all the duplicate issues (check for updates) you create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants