-
-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color theme revamp #7561
Color theme revamp #7561
Conversation
cd3d66d
to
d5f8927
Compare
A welcome change, thanks sledgehammer999! |
the new background color seems a bit bright for dark mode, doesn't it? |
It's probably a matter of one's preference. IMO, black is too dark for me as background. I would suggest this: Just browse the Nord theme website and switch to dark mode via the relevant UI element. Then you'll get a better feel for it.
If we disregard the background darkness(black or nord0), the contrast is exactly the issue for me. |
For completeness sake there are a few other popular color themes for dark modes out there: |
--nord14: #a3be8c; | ||
--nord15: #b48ead; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose in an ideal world, just these color names would be set depending on dark-mode or light-mode. Everything else could then just refer to names instead of concrete colors
Woah, you've merged it! Thank you. |
The current dark theme makes the online documentation a pain to read.
I took the liberty of implementing the color palette from the Nord Theme.
I am not sure that I got it right, but IMO it is more readable now than it was before. (I am a noob on the topic of colors)
I didn't touch the colors for the
NOTE
andWARNING
alert boxes, because I don't have any idea on how the make them work correctly with Nord's color palette.BEFORE
AFTER