Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the wrong port is being announced to tracker #7596

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fix the wrong port is being announced to tracker #7596

merged 1 commit into from
Feb 1, 2024

Conversation

glassez
Copy link
Contributor

@glassez glassez commented Jan 30, 2024

Closes #7595.

@glassez glassez mentioned this pull request Jan 30, 2024
Closed
@tainewoo
Copy link

Thank you so much.
This issue blocks lots of users to move on to libtorrent v2.x.
With this fix, lots of them might try to move on to the newer versions.

@Pentaphon
Copy link

@arvidn please make this a priority as this is a major issue according to many tracker users in the qBittorrent community who use private trackers.

arvidn
arvidn approved these changes Feb 1, 2024
View reviewed changes
Copy link
Owner

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find!

@arvidn arvidn merged commit cf08820 into arvidn:RC_2_0 Feb 1, 2024
41 of 42 checks passed
@glassez glassez deleted the fix-wrong-announced-port branch February 1, 2024 12:05
@glassez
Copy link
Contributor Author

glassez commented Feb 1, 2024

@arvidn
While dealing with this problem, I found that portmap alert message does not contain the source port (this information is generally not available through the alert interface), and this is an essential part of the information about established port mapping.

@KyleSanderson
Copy link

good find!

Can you ship 2.0.10?

@KyleSanderson KyleSanderson mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong port is announced to tracker
5 participants
@glassez @tainewoo @Pentaphon @KyleSanderson @arvidn