Keep replacing hpd with hdi #1190
Conversation
|
You are too kind @aloctavodia. An |
| hpd_fill_kwargs.setdefault("label", "Uniform HPD") | ||
| hpd_kwargs["fill_kwargs"] = hpd_fill_kwargs | ||
| hpd_kwargs["credible_interval"] = credible_interval | ||
| if use_hdi: |
There was a problem hiding this comment.
for loo pit I left it hpd because this particular case it is hpd. I don't think loo pit makes sense for anything bu the posterior. Not opposed to changing it but wanted to get your thoughts
There was a problem hiding this comment.
that's true, but having hpd and hdi seems to me like a source of potential confusion for users or even ourselves in the future
| @@ -184,7 +184,7 @@ def plot_posterior( | |||
|
|
|||
| >>> az.plot_posterior(data, var_names=['mu'], kind='hist') | |||
|
|
|||
| Change size of HPD interval | |||
| Change size of highest density interval | |||
There was a problem hiding this comment.
Thanks for catching my misses
There was a problem hiding this comment.
I did not remove any function (at least not on purpose, haha) I just marked plot_hpd as deprecated in favor of plot_hdi. And I replaced the strings hpd to hdi.
There was a problem hiding this comment.
Ah yes you're right I see it now
|
|
||
|
|
||
| def plot_hpd(*args, **kwargs): | ||
| warnings.warn("plot_hdi has been deprecated, please use plot_hdi", DeprecationWarning) |
There was a problem hiding this comment.
Pydocstyle complaining about this one method. Maybe add disable or deprecation comment to get a pass
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
+ Coverage 93.23% 93.26% +0.02%
==========================================
Files 94 94
Lines 9376 9381 +5
==========================================
+ Hits 8742 8749 +7
+ Misses 634 632 -2
Continue to review full report at Codecov.
|
|
LGTM merging |
Fix #1186