Prevent wrapping group names in InferenceData HTML repr #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd appreciate any suggestions on a good test for this. |
|
The failures don't seem to be unique to this PR (they also show up in e.g. #1406). |
|
Thanks, Seth! I'm not super worried that we do a great job testing CSS :D |
ahartikainen
pushed a commit
that referenced
this pull request
Oct 5, 2020
* Reset grid for group names * Update changelog
ahartikainen
added a commit
that referenced
this pull request
Oct 5, 2020
* update draws call and fix prior * check if draws exists * update changelog * fix new and old parsing * Prevent wrapping group names in InferenceData HTML repr (#1407) * Reset grid for group names * Update changelog * make some sets Co-authored-by: ahartikainen <ahartikainen@github.com> Co-authored-by: Seth Axen <seth.axen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HTML repr for
InferenceDatareuses some of the classes of xarray's HTML repr forxarray.Dataset.The
xr-sectionsclass determines the grid layout of the list of sections in theDatasetrepr. However, the same class is applied to the list of groups in theInferenceDatarepr. The result is that the same grid layout is applied to both (note that the left-most and two right-most columns are the same width):This isn't a problem in the arviz docs or Jupyter notebooks with the default theme, but a different Jupyter theme is used or the
InferenceDataHTML repr is used in a different page, then if the font size is too large, the group names can exceed the fixed width of the grid. This happens in the ArviZ.jl docs, because they use a different font size than the arviz docs (thanks to @ColCarroll for pointing that out!)This PR adds a
group-sectionssubclass toxr-sectionsthat is used for the groups list, and in the CSS resets the grid for just that list while keeping all other CSS attributes. The result is that only the grid is changed:Checklist