-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use arviz_example_data submodule #2096
Conversation
The azure errors seem related to this: https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#checkout. IIUC, by default, submodules are not cloned, but I don't completely understand how to get them to clone |
Thanks! Still some kinks to iron out for specific builds, but it seems to work for some of them now. |
Looks great already, let's merge arviz-devs/arviz_example_data#6 to make it easier, thanks for getting this started |
@OriolAbril do you know how to tell black to skip the |
It should be done from pyproject.toml. I think if you add something like this to the
ref: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-format |
This reverts commit 296f279.
The remaining errors seem to also occur on main and be unrelated to this PR. This is now ready for review. |
Codecov Report
@@ Coverage Diff @@
## main #2096 +/- ##
=======================================
Coverage 90.78% 90.79%
=======================================
Files 117 117
Lines 12484 12488 +4
=======================================
+ Hits 11334 11338 +4
Misses 1150 1150
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks! I also want to put on record that out of the last 4 PRs we have merged, 3 of them recuded the number of code lines while improving or maintaining functionality! 🎉 |
Description
Replaces stored example data with arviz_example_data based on arviz-devs/arviz_example_data#6. Note: this should not be merged until that PR is merged!
Checklist
📚 Documentation preview 📚: https://arviz--2096.org.readthedocs.build/en/2096/