Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arviz_example_data submodule #2096

Merged
merged 22 commits into from
Aug 17, 2022
Merged

Use arviz_example_data submodule #2096

merged 22 commits into from
Aug 17, 2022

Conversation

sethaxen
Copy link
Member

@sethaxen sethaxen commented Aug 15, 2022

Description

Replaces stored example data with arviz_example_data based on arviz-devs/arviz_example_data#6. Note: this should not be merged until that PR is merged!

Checklist

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2096.org.readthedocs.build/en/2096/

@OriolAbril
Copy link
Member

The azure errors seem related to this: https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#checkout. IIUC, by default, submodules are not cloned, but I don't completely understand how to get them to clone

@sethaxen
Copy link
Member Author

sethaxen commented Aug 16, 2022

Thanks! Still some kinks to iron out for specific builds, but it seems to work for some of them now.

@OriolAbril
Copy link
Member

Looks great already, let's merge arviz-devs/arviz_example_data#6 to make it easier, thanks for getting this started

@sethaxen
Copy link
Member Author

@OriolAbril do you know how to tell black to skip the example_data directory? I tried to do it with pylintrc but it seems was not successful.

@OriolAbril
Copy link
Member

OriolAbril commented Aug 16, 2022

It should be done from pyproject.toml. I think if you add something like this to the tool.black section:

extend_exclude = 'example_data'

ref: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-format

@sethaxen sethaxen changed the title [WIP] Use arviz_example_data submodule Use arviz_example_data submodule Aug 17, 2022
@sethaxen
Copy link
Member Author

The remaining errors seem to also occur on main and be unrelated to this PR. This is now ready for review.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #2096 (de5589d) into main (8a2bc39) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2096   +/-   ##
=======================================
  Coverage   90.78%   90.79%           
=======================================
  Files         117      117           
  Lines       12484    12488    +4     
=======================================
+ Hits        11334    11338    +4     
  Misses       1150     1150           
Impacted Files Coverage Δ
arviz/data/datasets.py 98.48% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriolAbril OriolAbril merged commit 5ca7643 into main Aug 17, 2022
@OriolAbril OriolAbril deleted the exdatasubmod branch August 17, 2022 08:44
@OriolAbril
Copy link
Member

Thanks!

I also want to put on record that out of the last 4 PRs we have merged, 3 of them recuded the number of code lines while improving or maintaining functionality! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants