Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow observed data to inherit dims #247

Merged
merged 2 commits into from
Sep 19, 2018

Conversation

ColCarroll
Copy link
Member

Using a pattern like

data = az.pystan_to_inference_data(fit=fit, 
                                observed_data=['y'], 
                                coords={'school': schools},
                                dims={'theta': ['school'], 'y': ['school']})

throws an exception without this change.

@canyon289
Copy link
Member

LGTM waiting for tests to pass

@ColCarroll
Copy link
Member Author

ColCarroll commented Sep 18, 2018

hold on for a sec - adding this case to the test suite. might have to clear the cache on travis, so it will take a while.

@ahartikainen
Copy link
Contributor

ahartikainen commented Sep 18, 2018

LGTM.

This is assuming we are changing pccplot and observed data to match ppsample.

@ColCarroll
Copy link
Member Author

Just deleted caches and restarted travis. This is good to merge if tests pass (also fine waiting for #248 since mine is easier to rebase).

@ColCarroll ColCarroll merged commit 332ab19 into arviz-devs:master Sep 19, 2018
@ColCarroll ColCarroll deleted the pystan-observed branch January 30, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants