Add coords and ax arguments to all plotting functions #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified get_coords to work on tuple or lists of xarray datasets too
OriolAbril
force-pushed
the
add_coords_and_ax
branch
from
24aac74
to
af460e8
Compare
It is added as ax_tuple argument to mimic the output type of the function.
arviz/plots/jointplot.py
Outdated
| @@ -20,6 +20,7 @@ def plot_joint( | |||
| fill_last=True, | |||
| joint_kwargs=None, | |||
| marginal_kwargs=None, | |||
| ax_tuple=None, | |||
There was a problem hiding this comment.
I'd rather ax like the other functions or something clearly different like I tried. It it is okey I'll change it by ax
There was a problem hiding this comment.
It is conceptually different than the other functions but you can always overlay plots doing:
ax = plot_xyz(data1)
az.plot_xyz(data2, ax=ax)
so maybe for the end users there is not much difference
|
Is this ready to merge? |
|
Yes! I was originally planning on addind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
plot_xyzhavecoordsandaxarguments, but there are some exceptions. This PR intends to add these arguments in all functions (if they make sense,plot_comparewill continue not havingcoordsargument).I have started with
plot_forest, fixes #813. Similarly to what happened inplot_density, it can also accept a list of inferencedata objects, so I modifiedget_coords. I set it to accept 3 combinations:This allows to handle idata objects with different dimensions, but I am not totally convinced by this approach. Any ideas will be welcome.
axargument added toplot_joint