Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional dependency class #89

Merged
merged 1 commit into from
May 21, 2018

Conversation

ColCarroll
Copy link
Member

This is a way to use methods from pymc3 or altair when it is clear the user wishes to use such a method. For example, if the user passes a pymc3 trace, I think it would be fair to use a method from arviz.compat.pymc3.

I also plan to use this to implement some methods using arviz.

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 165

  • 0 of 16 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 77.763%

Changes Missing Coverage Covered Lines Changed/Added Lines %
arviz/compat/init.py 0 3 0.0%
arviz/compat/optional_dep.py 0 13 0.0%
Totals Coverage Status
Change from base Build 163: -0.8%
Covered Lines: 1196
Relevant Lines: 1538

💛 - Coveralls

@ColCarroll
Copy link
Member Author

also just turned off coveralls comments. can re enable if you find them useful. there are no tests here because it is quite difficult to test, but I can add those if you'd like (I think pymc3 enforces that matplotlib is not required).

@aloctavodia
Copy link
Contributor

aloctavodia commented May 20, 2018

I like the coveralls comments turned off and I am OK about skipping the tests. I don't really understand what this new class is for, but I guess I will when you use it for something concrete, so feel free to merge this.

@ColCarroll
Copy link
Member Author

Sorry for not explaining better!

My immediate use case is to implement something like traceplot_altair, as well as to get rid of some pymc3 specific code: it seems like arviz.trace_to_dataframe(trace) should call pymc3.trace_to_dataframe if trace is a multitrace from pymc3.

@ColCarroll ColCarroll merged commit 461d07f into arviz-devs:master May 21, 2018
@aloctavodia
Copy link
Contributor

OK I see now, thank you. I do not remember exactly what I changed, but I think ArviZ's trace_to_dataframe is not the same that the one from PyMC3. I will check it tomorrow, dinner is waiting! :-)

@ColCarroll ColCarroll deleted the optional_deps branch July 4, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants