Fix scipy's solve_lyapunov and update testing #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvoelke
force-pushed
the
fix_solve_lyapunov
branch
from
036b5ef
to
e09e238
Compare
arvoelke
commented
Dec 4, 2017
setup.cfg
Outdated
| @@ -3,6 +3,7 @@ description-file = README.rst | |||
|
|
|||
| [flake8] | |||
| exclude = _*.py,docs/*.py,build/*.py | |||
| ignore = E741 | |||
There was a problem hiding this comment.
Suppressing:
nengolib/signal/discrete.py:132:9: E741 ambiguous variable name 'I'
nengolib/signal/lyapunov.py:181:5: E741 ambiguous variable name 'O'
nengolib/signal/lyapunov.py:223:8: E741 ambiguous variable name 'O'
nengolib/signal/realizers.py:87:9: E741 ambiguous variable name 'I'
nengolib/signal/system.py:682:9: E741 ambiguous variable name 'I'
nengolib/signal/tests/test_realizers.py:59:5: E741 ambiguous variable name 'I'
nengolib/signal/tests/test_system.py:208:5: E741 ambiguous variable name 'I'```
Repository owner
deleted a comment from
codecov-io
Dec 4, 2017
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 28 28
Lines 1321 1324 +3
Branches 155 155
=====================================
+ Hits 1321 1324 +3
Continue to review full report at Codecov.
|
arvoelke
force-pushed
the
fix_solve_lyapunov
branch
from
e09e238
to
f597394
Compare
arvoelke
commented
Dec 4, 2017
| @@ -3,6 +3,7 @@ description-file = README.rst | |||
|
|
|||
| [flake8] | |||
| exclude = _*.py,docs/*.py,build/*.py | |||
| ignore = E226,E741 | |||
There was a problem hiding this comment.
E226 is another new error for whitespace around arithmetic operator...
arvoelke
commented
Dec 4, 2017
| @@ -337,11 +340,13 @@ def _normtail(sig, A, x, C): | |||
| x = _state_impulse(Phi, x0=B, k=N, delay=0) # eq (38) | |||
| abs_e = np.squeeze(abs(C.dot(x.T))) | |||
| x = x[:-1] # compensate for computing where thresholds crossed | |||
| abs_y = abs_y[:-1] # compensate for computing where thresholds crossed | |||
There was a problem hiding this comment.
Removing this line gives a warning that I was ignoring before, due to abs_y[cross] having mismatched shapes between the boolean index cross and abs_y (latter had an extra dimension).
arvoelke
force-pushed
the
fix_solve_lyapunov
branch
from
f597394
to
4f7f50e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129.