Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed text from beautiful soup. #351

Merged
merged 1 commit into from
May 6, 2024
Merged

Fix malformed text from beautiful soup. #351

merged 1 commit into from
May 6, 2024

Conversation

bohou-aryn
Copy link
Collaborator

Seems the problem of below

<div><span>hello</span></div><div><span>world</span></div> ->
"helloworld" instead of "hello" "world"

is due to no separator is added when concatenate string when getting text

Seems the problem of below

```
<div><span>hello</span></div><div><span>world</span></div> ->
"helloworld" instead of "hello" "world"
```
is due to no separator is added when concatenate string when getting
text
Copy link
Collaborator

@HenryL27 HenryL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -93,7 +93,7 @@ def test_html_partitioner(self, partitioner, read_local_binary, expected_partiti
(
HtmlPartitioner(extract_tables=True),
TEST_DIR / "resources/data/htmls/wikipedia_binary_search.html",
77,
74,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must be missing something but why does this make the number go down?

@bsowell bsowell merged commit adb442a into main May 6, 2024
9 of 12 checks passed
@bsowell bsowell deleted the htmlpartiioner branch May 6, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants