[OIL-190] IE10 e2e test upgrades #150
Conversation
Pull Request Test Coverage Report for Build 292
💛 - Coveralls |
src/scripts/core/core_config.js
Outdated
| @@ -170,6 +170,10 @@ export function getLanguage() { | |||
| } | |||
|
|
|||
| export function getLanguageFromLocale(localeVariantName) { | |||
| if(!localeVariantName) { | |||
| logError('localeId missing in locale'); | |||
| localeVariantName = 'en'; | |||
There was a problem hiding this comment.
@ltparis2018 can you confirm if it is OK to pass a default here? It does not break any test.
There was a problem hiding this comment.
Yes, this is ok. OIL layer's default language is english. But the error message needs an improvement I think. What is locale id in this context? Or locale? This method does not know anything about the origin of given localeVariantName. For example, this method is invoked during outdated cookie transformation that does not know a locale or a locale id.
package.json
Outdated
| @@ -123,6 +124,7 @@ | |||
| "pretty": "2.0.0", | |||
| "puppeteer": "1.4.0", | |||
| "raw-loader": "0.5.1", | |||
| "regenerator-runtime": "^0.11.1", | |||
There was a problem hiding this comment.
Tried to mimic what babel-polyfill does here, looking for a solution. Deleting
src/demos/auto-hide.html
Outdated
| @@ -26,7 +26,7 @@ | |||
| <script id="oil-configuration" type="application/configuration"> | |||
| { | |||
| "poi_group_name": "axelSpringerSe_01", | |||
| "timeout" : "2" | |||
| "timeout" : "3" | |||
There was a problem hiding this comment.
What is this for? It makes the test wait 1s longer!
| } | ||
| require('core-js/modules/es6.object.assign'); |
There was a problem hiding this comment.
No way we need all this polyfills!
There was a problem hiding this comment.
Have reduced them to the absolute necessary
There was a problem hiding this comment.
This is super strange:
oil.js 19.569 kB -> 19.43 kB it got smaller!!!
hub.js 11.239 kB -> 17.496 kB okay, this has the polyfills
| .assert.containsText('html', 'Custom Purpose 1', 'Checking custom purpose title') | ||
| .pause(100) | ||
| .useCss() | ||
| // deactivate because opening the page in IE10 and 9 the custom purposes, only the e2e test fails |
There was a problem hiding this comment.
You should add a FIXME and the ticket number of the Jira Ticket you created.
test/e2e/auto_hide_test.js
Outdated
| @@ -21,7 +21,7 @@ module.exports = { | |||
| 'OIL Layer should be auto-hidden after the correct amount of time': function (browser) { | |||
| browser | |||
| .pause(500) | |||
| .waitForElementVisible(OIL_LAYER, 500, false) | |||
| .waitForElementVisible(OIL_LAYER, 2000, false) | |||
| .pause(2000) | |||
| .useXpath().waitForElementNotPresent(OIL_LAYER, 500) | |||
There was a problem hiding this comment.
If the timeout is 3s, how can this ever work?!
| echo "- Testing $1 -" | ||
| echo "..." | ||
| echo "-------------------------" | ||
| echo "試）TESTING $1" |
There was a problem hiding this comment.
The Japanese I know but probably the same character in Chinese, too.
試す【ためす】= to attempt; to test; to try out
I've put it in as an eye catcher
Fixing tests for IE10. CPC and POI tests fail because they rely on the backend which does not have the required polyfills yet.