Oil 214 cpc spring #165
Merged
Oil 214 cpc spring #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abels and remove documentation for obsolete labels
added 3 commits
July 10, 2018 14:02
* master: Trying to stabilize tests Increment version Adding new release 1.2.1-RELEASE Fixing e2e tests on old chromes Fixing e2e tests on ipads Trying to FIX e2e tests Fix review issues Dont try being smart Return gdpr_applies_globally value from config in ping response Rename api function to applyGDPR() for clarity Refactor for clarity of variable names Add test page for gdpr_applies config element Add setGdprApplies function no ticket: fix double invocation of tag management at startup add getVendorConsentData and getConsentDataString test for gdpr_applies when gdpr_applies should not render oil add gdpr_applies config to readme Rename file spelling Fix configuration load value Fix test add gdprApplies config and wire it to cookie # Conflicts: # src/styles/cpc_standard.scss # test/e2e/advanced_settings_custom_purposes_test.js # test/test_constants.js
phogel
approved these changes
Jul 10, 2018
Pull Request Test Coverage Report for Build 454
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.