Oil 292/load vendor list refactoring #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 800
💛 - Coveralls |
ltparis2018
suggested changes
Oct 8, 2018
| }); | ||
| if (pendingVendorlistPromise) { | ||
| return pendingVendorlistPromise; | ||
| } else if (cachedVendorList) { |
There was a problem hiding this comment.
For the unlikely case that pendingVendorlistPromise AND cachedVendorList exist I would prefer to check for cachedVendorList first.
| return pendingVendorlistPromise; | ||
| } else if (cachedVendorList) { | ||
| return new Promise(function (resolve) { | ||
| resolve(cachedVendorList); |
There was a problem hiding this comment.
Please use consistent function definition. Line 19 and 23 use "function() {}", line 26 use an arrow function.
| let iabVendorListUrl = getIabVendorListUrl(); | ||
| pendingVendorlistPromise = fetchJsonData(iabVendorListUrl) | ||
| pendingVendorlistPromise.then(response => { | ||
| cachedVendorList = response; |
There was a problem hiding this comment.
cachedVendorList should be assigned only if it's ready. Therefore, order should be: 1. sort - 2. assign. Otherwise, it would be possible that an unsorted vendor list is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.