Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent #5

Merged
merged 51 commits into from
May 5, 2018
Merged

Concurrent #5

merged 51 commits into from
May 5, 2018

Conversation

as
Copy link
Owner

@as as commented May 5, 2018 •
edited
Loading

This pull integrates the ui package with concurrent shiny. It additionally targets code-quality improvements, test coverage/documentation gaps, and code deduplication.

  • compatibility with concurrent shiny
  • ui/tag: works even when graphics are off
  • ui/tag: font size fix
  • lazy initialization: remove duplication of work in new, move, and resize constructors
  • new package: ui/col
  • new package: ui/img (experimental)
  • Unit tests

as added 30 commits February 24, 2018 22:58
@as
save
ab008d6
@as
ui: merge with concurrent shiny
a4d924b
@as
tag: remote print statements
ec04ec2
@as
tag: goimports
ba18a50
@as
ui: fixes for a
f944374
@as
ui: fix imports
9c57733
@as
ui: img: fix compile
228d1d2
@as
ui: win: backnl should be private
ece4f5f
@as
ui: tag: paste returns old dot
41fb150
@as
ui: tag: start image experiment
e285ae3
@as
ui: tag: make window an interface; add image experiment
bee58a9
@as
ui: add image experiment
7d72970
@as
ui: fix Select method
364a66b
@as
win: add guard to resize
837c384
@as
img: remove infinite recursion
8f4efa0
@as
tag: remove empty branch
9ca2a74
@as
ui: clean up more garbage
190c710
@as
ui: move col to this package
70bcf35
@as
col: change move formula; add test to detect resize on move condition…
021371f 
…s, which are invalid conditions
@as
ui: more tests
2075470
@as
ui: split column and the container that logically holds the slice of …
f3a7c27 
…planes
@as
ui: col: treat grid and col as isomorphic structures
0a1dd8f
@as
ui: win: remove print statement
ad7b6b2
@as
v0.0.1
4d572a4
@as
ui: drop sp,size from all new functions; use move and resize instead
9d54b17
@as
ui: tag: fix resize issue
2bd01ec
@as
ui: fix scrollbar; seperate implementation of scrollbar
609085a
@as
ui: scroll: seperate entirely from win; add documentation
7c86bcb
@as
ui: win: remove dependencies on scroller
53bc9c7
@as
util.go
7ce7aa5
as added 20 commits April 27, 2018 22:42
@as
ui: win: fix dirty override in upload; add option to toggle scrollbar
ba592b8
@as
ui: tag: remove a bit of default hell now that things are cleaner
ff97d60
@as
ui: tag: remove a bit of default hell now that things are cleaner
b4720b2
@as
col: fix all tests
0c8da5a
@as
ui: col: fix zero test and remove print stmt
cd40d42
@as
ui: tag: make default tag label size more fitting of the font face
2116cb4
@as
ui: win: add Area() and make scroll bar draw outline even when disabled
b90d79f
@as
win: move backnl
e6f76f5
@as
tag: remove unused clipboard functions
002e6ed
@as
tag: remove unused escR and pt, p functions
5316fd2
@as
tag: fix nil check in test
748b6bd
@as
ui: tag,col,win: make config less of a pain to manage
52d81fa
@as
ui: resize != upload (major fix)
054e519
@as
tag: fix test for tag after changing upload
6b9c1bf
@as
col: fix tests after upload fix
bc62dcb
@as
tag: remove unused range pair
9cdb314
@as
tag: move importer to a
e0d2074
@as
tag: elastic option should be set on config even if tag/window is not…
8811b61 
… graphical
@as
scroll: create a config and make it easier to set the color
85e091c
@as
win: fix font resize
d157556
@as as self-assigned this May 5, 2018
@as as merged commit c2f7f89 into master May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@as as

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@as