Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boxednode to create binaries #91

Merged
merged 59 commits into from
Dec 11, 2020
Merged

Add boxednode to create binaries #91

merged 59 commits into from
Dec 11, 2020

Conversation

asamuzaK
Copy link
Owner

@asamuzaK asamuzaK commented Dec 9, 2020

No description provided.

@asamuzaK
Copy link
Owner Author

asamuzaK commented Dec 9, 2020

@mb720
Hi, I'm going to switch from js2bin to boxednode to create binaries.
Can you try v6.x pre-release binary and tell me if it works or not?
Releases · asamuzaK/withExEditorHost

Thanks

@mb720
Copy link
Contributor

mb720 commented Dec 9, 2020

Sure!
I'm using the new index now but I can see the red box with the exclamation mark on withExEditor's icon. What do you think is the best way to debug this?

@asamuzaK
Copy link
Owner Author

asamuzaK commented Dec 9, 2020

  • Check the permissions of the binary.
    Does it have an executable bit?
    If not, change permission to 755.
  • Move to the directory where you saved the binary.
    cd path/to/binary
    index -h
    
    Is help displayed?

@mb720
Copy link
Contributor

mb720 commented Dec 10, 2020

Right, I forgot to set the executable bit 🤦
Thanks for pointing that out.
The new withExEditorHost seems to work great. I'm writing this using Neovim ❤️

@asamuzaK
Copy link
Owner Author

It should be 755 by default.
I will create another try build later and get in touch with you again.
Thank you.

@asamuzaK
Copy link
Owner Author

@mb720
New try build is ready, v6.0.0-a.11
Please check if the permission of the unzipped binary is 755 by default

Thanks

@asamuzaK
Copy link
Owner Author

Ah, please wait.
zipped package is only 7KB
I'll re-run the build.

@asamuzaK
Copy link
Owner Author

@mb720
Re-built with success.
Please check if the permission of the unzipped binary is 755 by default.

Thanks

@asamuzaK
Copy link
Owner Author

@mb720
New try build.
GitHub actions seems to have an issue with zipping files (or, maybe its by design).
Anyway, assets for linux and macos are now tar.gz, not zip.
Please check if the permission of the binary is 755 by default.

Thanks

@mb720
Copy link
Contributor

mb720 commented Dec 11, 2020

Yes, index is 755.
I also tested whether the new version works for writing with Neovim: All good! 👍

@asamuzaK
Copy link
Owner Author

Thanks!

@asamuzaK asamuzaK merged commit 4edd74c into master Dec 11, 2020
@asamuzaK asamuzaK deleted the boxednode branch December 11, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants