-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roomstat battery levels seem wrong #90
Comments
Is this using 2.1 or the beta release i did last night (2.2alpha) |
Im seeing this now, actually I think this is a bug in the itrv (which I added last night).. The battery % is wrong, I forgot to take into account the "base" voltage.. Can u confirm? |
I've pushed a fix makes the values uniform across trv and battery sensor. I could create a new release (R2.2alpha2) but I am thinking that its one file and easy for you to test. can you patch the sensor.py file? Easiest way is
and then replace your sensor.py? Now back to work, got loads to do today :-( |
Just a comment from me that was outstanding from the v2.0 release as to whether the BATTERY_MIN value is set correctly in const.py. I think it maybe set too low to be correctly identifying low battery level in the TRVs and when they need replacing. @asantaga this was based on your conversations previously with Wiser. We may want to make a decision on what the min should be on this basis. |
Using sensor.py from 5ebca8b#diff-0ff60fdf1d7d6163cfccdfbfd01a6660 had no effect :( |
I was looking at this and for all of my devices i see :
I didnt have any more than 2.9 ( in theory two x 1.5 batteries are going to be 30 or maybe 31 I'm thinking if we use 25 as the MIN and 30 as the max then the figures look like this, and corresponding WISER text
The issue is that at 26 the batteries are probably not "Dead" but pretty much dead for Wiser Seeing https://trueadolescents.com/aa-battery-voltage-range/ , apparently 1.5v cells are considered dead at 1.2v (ie 2.4v for 2) so 25 is probably a good value ( i tried 24 and the results dont match what wiser think).. Go with 25 as Min and 30 as Max? |
I think that sounds good. When previously playing, I was ending up with weird % values but doing in 20's I think looks good. I think I have seen 31 but agreed it wouldn't last long at this level and so long as we ensure that anything over 30 shows as 100% I think that will work well. |
I'll modify the constants now and also modify the code so we dont report % more than 100 :-) , just in case! |
Initial commit done in 896723c and Im happy with TRV values matching (roughly) what wiser reports in text.. BUT the values dont ring true for roomstats.. itrvs are considered dead at 25 but roomstats go much lower.. Currently my room stat is at voltage 25 (2.5v) and wiser reports them as "NORMAL", need a few more measurements to work out what low is for a roomstat.. |
roomstat is 2.9v normal |
Roomstat. |
Mines also 29 and Normal. Not much variation to help you, sorry |
mmm so 29 is Normal and 24 TwoThirds... we'd need one more measurement to understand the range.. I think Im gonna have to find some old batteries from my son's toys |
good call, let me find shitty batteries and throw them in |
I have a variable voltage supply arriving tomorrow so will connect to roomstat and a trv, do tests on the whole range and report back the status from the hub. |
Ok. Have done testing on Roomstat and results are below: 2.5v+ - Normal Will do same testing on a iTRV to make sure we are consistent. |
iTRV is as below |
cool, I actually found a few batteries and yeah about the same results ( i only tested the room stat) I'll implement this tonight. I'll leave TRVs as they are , and do roomstats 1.7 to 2.7 as the range.. |
this is done, please test in from the dev branch. , however to me looks right. I'll merge into master tomorrow and make a 2.2 release if all good. if there are any issues then reopen the issue, |
2.x -> 30%
1.9: -> 77% (this value seems correct as its this value in the app and on the thing itself aswell)
the iTRVs seem fine, which is weird since its the same formula that is used
The text was updated successfully, but these errors were encountered: