Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store configs in the dll's directory #35

Closed
tico-tico opened this issue Jul 1, 2015 · 2 comments
Closed

Store configs in the dll's directory #35

tico-tico opened this issue Jul 1, 2015 · 2 comments

Comments

@tico-tico
Copy link
Contributor

I think it could be very useful for some people like me. I changed PluginData.cpp (lines 433 - 435) to this

#elif JUCE_WINDOWS
    if ( File::getSpecialLocation(File::currentExecutableFile).getSiblingFile("Dexed_data").isDirectory() )
        dexedAppDir = File::getSpecialLocation(File::currentExecutableFile).getSiblingFile("Dexed_data");
    else
        dexedAppDir = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile("DigitalSuburban").getChildFile("Dexed");
#else

and it worked. I mean if user manually creates the "Dexed_data" folder in the dll's dir then plugin will use it instead of system App's Data folder.

What do you think?

BTW it looks like you forgot to initialize showKeyboard so the keyboard randomly on/off if no config file is found. (Your checking if ( prop.containsKey( String("showKeyboard") ) ) doesn't allow JUCE to use default zero value.)

Edit:
use currentExecutableFile everywhere for consistency (accidentally left currentApplicationFile in the code after testing, although they are the same for Win).

@asb2m10
Copy link
Owner

asb2m10 commented Jul 20, 2015

I'm against using the default "VST" directory has a config path since on Windows and OS X this directory is owned by root/Administrator. I would need to make an installer and this is something I really don't want.

That said, for experienced users (and not just for Windows), the binary directory makes sense... I will add this to the next version.

Thanks for the missing "showKeyboard" option.

@asb2m10
Copy link
Owner

asb2m10 commented Jul 24, 2015

Code is now committed on branch work-0.9.1. Thanks.

@asb2m10 asb2m10 closed this as completed Jul 24, 2015
asb2m10 pushed a commit that referenced this issue Apr 27, 2020
This commit provides initial support for MPE. That support consists of

1. MPE Enabled mode and MPE Pitch Bend Range both on PARAM screen
2. All MPE gestures captured per voice (so aftertouch, timbre, pb, and off vel)
3. MPE voice management by channel when MPE is enabled
4. Pitch Bend modification in MPE mode to handle bend gestures

It does not include any mapping of the aftertouch, timbre, or off velocity

Addressed #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants