Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRS: Assumptions #21

Closed
GenevaS opened this issue Oct 10, 2017 · 2 comments
Closed

SRS: Assumptions #21

GenevaS opened this issue Oct 10, 2017 · 2 comments
Assignees

Comments

@GenevaS
Copy link

GenevaS commented Oct 10, 2017

I have a few questions here:

  • For the order of RK, is the assumption that only second and fourth order methods will be used? Stating that "the user will specify..." sounds more like an input requirement and belongs elsewhere (e.g. an input specification or a user responsibility).
  • Stating that your ODEs must be stiff and continuous belongs here rather than stating it in your Goals section (i.e. remove it from your goal section so that it has a broader starting scope and narrow it with your assumptions)
  • Isn't stating that the output of the vector of an ODE must match the size of the input vector part of the correct solution specification (Output subsection)?
@GenevaS GenevaS mentioned this issue Oct 10, 2017
aschaap added a commit that referenced this issue Dec 18, 2017
…ical Models section to address issue #18; also addressed Dr. Smith's comments (#25) for this section, as well as the next (assumptions), which has been updated to address issue #21
@aschaap
Copy link
Owner

aschaap commented Dec 18, 2017

  • I've updated the first assumption to reflect the change you suggested.
  • I added a reference to this assumption in the goals section, rather than removing it entirely.
  • It's referencing the output of the ODE, which is an input; I'm just making explicit that the ODE doesn't output vectors with more elements than the number of elements in the input.

@aschaap aschaap self-assigned this Dec 18, 2017
@GenevaS
Copy link
Author

GenevaS commented Dec 18, 2017

:)

@GenevaS GenevaS closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants