Handle list post data #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triat
reviewed
Sep 13, 2017
| @@ -120,17 +120,23 @@ def _clean_data(self, data): | |||
| You can define your own sensitive fields in your view by defining a set | |||
| eg: sensitive_fields = {'field1', 'field2'} | |||
| """ | |||
| data = dict(data) | |||
| # data = dict(data) | |||
There was a problem hiding this comment.
This line is needed (maybe not there) otherwise you'll modify the original values which you don't want
There was a problem hiding this comment.
for me this was giving error that's why I commented the code.
There was a problem hiding this comment.
Yes I totally understand but this is critical, if you don't do it, you will have other errors. Again you don't want to modify the data you send to your API
triat
reviewed
Sep 13, 2017
rest_framework_tracking/mixins.py
Outdated
| @@ -143,4 +151,4 @@ class LoggingErrorsMixin(BaseLoggingMixin): | |||
| Log only errors | |||
| """ | |||
| def _should_log(self, request, response): | |||
| return response.status_code >= 400 | |||
| i return response.status_code >= 400 | |||
There was a problem hiding this comment.
I think you have a typo here
triat
reviewed
Sep 13, 2017
| data = dict(data) | ||
| for key in data: | ||
| if key.lower() in SENSITIVE_FIELDS: | ||
| data[key] = CLEANED_SUBSTITUTE |
There was a problem hiding this comment.
We duplicate a lot of code here, instead of doing what you do we could have:
if type(data) is not list:
data_list = [data]
for data in data_list:
d = dict(data)
for key in d:
if key.lower() in SENSITIVE_FIELDS:
d[key] = CLEANED_SUBSTITUTE
return d
Closed
|
@triat @verisadmin This was fixed and merged from PR #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #71