Make Asciidoctor Options independent (#125) #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-125/main/make-asciidoctor-options-immutable
branch
3 times, most recently
from
2a72452
to
828b855
Compare
abelsromero
changed the title
abelsromero
force-pushed
the
issue-125/main/make-asciidoctor-options-immutable
branch
2 times, most recently
from
3857e05
to
0c9e6f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor construction of Asciidoctor options to make them independent
for each conversion. Now we can apply the original intended code where
we respect DocType if present.
Only template initialization is shared to reduce IO operations (create temp dirs).
Closes #125