Add darker font color recipe to kindle oasis too. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Wikipedia, Kindle Oasis has a definition of 1680 × 1264 pixels, 300 ppi. And according to asciidoctor#67, we can only detect the model of kindle by its definition. We just apply the same recipe as for PaperWhite here.
|
Just wanted to open a pull request, but you beat me to it :) |
|
I don't have access to Kindle Oasis. So, if @nscheer says it works, let it be so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Wikipedia, Kindle Oasis has a definition of
1680 × 1264 pixels, 300 ppi. And according to #67, we can only detect
the model of kindle by its definition. We just apply the same recipe
as for PaperWhite here.
Please note that this PR was not tested on a real device, but was triggered by progit/progit2#1438