Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logHandler configuration for site generation #400

Closed
2 tasks
abelsromero opened this issue Apr 23, 2019 · 0 comments · Fixed by #434
Closed
2 tasks

Support logHandler configuration for site generation #400

abelsromero opened this issue Apr 23, 2019 · 0 comments · Fixed by #434
Milestone

Comments

@abelsromero
Copy link
Member

The ability to fail on warning or error messages from asciidoctor is not supported when generating a site, only when using the main process-asciidoc mojo.

We should definitely support this.

We should consider:

  • Refactor current methods used to read XML configuration in AsciidoctorDoxiaParser in a separate component to ease testing and future refactoring. Should hide implementation as much as possible.
  • Implement support of same options logHandler options as the main process-asciidoc mojo.

/cc @ptahchiev feel free to give any feedback if you think this does not cover you use case.

@abelsromero abelsromero added this to the 2.0.0 milestone Apr 23, 2019
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant