Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tabset as openblock #15

Closed
mojavelinux opened this issue Oct 5, 2022 · 0 comments
Closed

Create tabset as openblock #15

mojavelinux opened this issue Oct 5, 2022 · 0 comments
Assignees
Labels
Milestone

Comments

@mojavelinux
Copy link
Member

mojavelinux commented Oct 5, 2022

Currently, the tabset is created entirely using passthrough blocks. The tabset should instead be created as an open block. This allows it to be better recognized by the referencing system and by code that operates on the parsed document such as a tree processor.

The only drawback of this change is that it will move the location of the div with the "content" class. That will require the following style change for anyone who has been using a custom stylesheet:

old:

.tabset > .content { ... }

new:

.tabset .tab-pane { ... }

It also means that the tab panes will no longer be enclosed, though another div could be added around them if need be.

UPDATE: The new structure is .tabs .tabpanel.

@mojavelinux mojavelinux added the enhancement New feature or request label Oct 5, 2022
@mojavelinux mojavelinux added this to the v1.0.x milestone Oct 5, 2022
@mojavelinux mojavelinux self-assigned this Oct 5, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-tabs that referenced this issue Dec 8, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-tabs that referenced this issue Dec 8, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-tabs that referenced this issue Dec 8, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-tabs that referenced this issue Dec 8, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-tabs that referenced this issue Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant