Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically refresh preview on preferences / settings change #447

Closed
danyill opened this issue Sep 17, 2021 · 1 comment · Fixed by #470
Closed

Automatically refresh preview on preferences / settings change #447

danyill opened this issue Sep 17, 2021 · 1 comment · Fixed by #470
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement
Milestone
2.8.10

Comments

@danyill
Copy link
Contributor

danyill commented Sep 17, 2021

When user preferences are changed, often a user has to type a key to get a preview refresh in this extension.
A number of user settings affect the preview refresh and it would provide better user experience if the preview automatically refreshed on a change in settings.
@danyill danyill added ✨ enhancement 💬 discussion Disccussion on new features, projects, etc... labels Sep 17, 2021
@danyill
Copy link
Contributor Author

danyill commented Oct 19, 2021

I think this may be quite easy after a small penny dropped this evening. PR soon.

@danyill danyill mentioned this issue Oct 19, 2021
Merged
@danyill danyill added this to the 2.8.10 milestone Oct 19, 2021
danyill added a commit to danyill/asciidoctor-vscode that referenced this issue Oct 19, 2021
@danyill
Update preview on preferences change (closes asciidoctor#447)
6bf9956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement
Projects
None yet
Milestone
2.8.10
Development

Successfully merging a pull request may close this issue.

Update preview on preferences change danyill/asciidoctor-vscode
1 participant
@danyill