Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code folding on open block #559

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Add code folding on open block #559

merged 2 commits into from
Mar 31, 2022

Conversation

marieflorescontact
Copy link
Collaborator

No description provided.

ggrossetie
ggrossetie requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments.
I don't think that the assertions are correct and I would like to add more test cases to make sure that the implementation is working as expected.

@marieflorescontact marieflorescontact force-pushed the Add-code-folding-on-code-block branch 2 times, most recently from 53305ad to 3be2e89 Compare March 31, 2022 13:30
@ggrossetie ggrossetie self-requested a review March 31, 2022 16:09
ggrossetie
ggrossetie approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks 👍🏻

@ggrossetie ggrossetie merged commit 2824561 into asciidoctor:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marieflorescontact @ggrossetie