Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-existent source roots raise an unwanted IOException. #85

Closed
ascopes opened this issue Feb 4, 2024 · 0 comments · Fixed by #88
Closed

Non-existent source roots raise an unwanted IOException. #85

ascopes opened this issue Feb 4, 2024 · 0 comments · Fixed by #88
Assignees
@ascopes
Labels
bug Something isn't working

Comments

@ascopes
Copy link
Owner

ascopes commented Feb 4, 2024

If no source roots are present on the source path, then the ProtoSourceResolver throws a NoSuchFileException rather than exiting successfully having run nothing.
@ascopes ascopes added the bug Something isn't working label Feb 4, 2024
@ascopes ascopes self-assigned this Feb 4, 2024
ascopes added a commit that referenced this issue Feb 4, 2024
@ascopes
GH-85: Add test cases for empty/missing source roots
a97e1fd
ascopes added a commit that referenced this issue Feb 4, 2024
@ascopes
GH-85: Fix unexpected exception being raised if no sources are found …
ee236fe 
…due to a missing directory/archive
@ascopes ascopes mentioned this issue Feb 4, 2024
Merged
ascopes added a commit that referenced this issue Feb 4, 2024
@ascopes
GH-85: Add test cases for empty/missing source roots
2808afd
ascopes added a commit that referenced this issue Feb 4, 2024
@ascopes
GH-85: Fix unexpected exception being raised if no sources are found …
356605f 
…due to a missing directory/archive
ascopes added a commit that referenced this issue Feb 4, 2024
@ascopes
Merge pull request #88 from ascopes/bugfix/GH-85-empty-source-roots
a9dafc9 
GH-85: Do not crash if source roots are missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ascopes ascopes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-85: Do not crash if source roots are missing ascopes/protobuf-maven-plugin
1 participant
@ascopes