Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-277: Support explicit plugin ordering #278

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Jun 30, 2024

  • Add new feature that allows users to explicitly order plugins across multiple POMs by specifying <order>12345</order>.
  • Document new behaviour.
  • Document plugin common attributes in one place.
  • Implement integration test for ordering.

Fixes GH-277.

@ascopes ascopes added documentation Improvements or additions to documentation new feature A new user-facing feature. integration-tests labels Jun 30, 2024
@ascopes ascopes added this to the 2.3.x milestone Jun 30, 2024
@ascopes ascopes self-assigned this Jun 30, 2024
@ascopes ascopes force-pushed the feature/gh-277-plugin-ordering branch from 8c8504a to e235d01 Compare June 30, 2024 10:24
@ascopes ascopes force-pushed the feature/gh-277-plugin-ordering branch 2 times, most recently from e5c4dc7 to 11ab671 Compare June 30, 2024 10:54
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (d61e936) to head (0b7713a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   87.75%   87.84%   +0.09%     
==========================================
  Files          35       35              
  Lines        1004     1011       +7     
  Branches       73       73              
==========================================
+ Hits          881      888       +7     
  Misses         94       94              
  Partials       29       29              
Files Coverage Δ
...bufmavenplugin/generation/SourceCodeGenerator.java 84.83% <100.00%> (+0.57%) ⬆️
...protobufmavenplugin/mojo/AbstractGenerateMojo.java 100.00% <ø> (ø)
...tobufmavenplugin/plugins/BinaryPluginResolver.java 71.19% <100.00%> (+0.50%) ⬆️
...protobufmavenplugin/plugins/JvmPluginResolver.java 78.95% <100.00%> (+0.38%) ⬆️
...opes/protobufmavenplugin/plugins/ProtocPlugin.java 100.00% <100.00%> (ø)

@ascopes ascopes force-pushed the feature/gh-277-plugin-ordering branch from 11ab671 to 0b7713a Compare June 30, 2024 11:09
@ascopes ascopes merged commit 44595a5 into main Jun 30, 2024
13 checks passed
@ascopes ascopes deleted the feature/gh-277-plugin-ordering branch June 30, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation new feature A new user-facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ordering Protoc plugins
1 participant