Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-78: Replace the 'binaryPlugin' attribute with two separate attributes #81

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Feb 3, 2024

Breaking change

Replaces the binaryPlugins Plugin attribute type used for binary plugins and replaces it with
two attributes:

  • binaryMavenPlugins - for Maven resolvable dependencies mapping to executables.
  • binaryPathPlugins - for executables on the system $PATH.

In addition, the jvmPlugins attribute has been renamed to jvmMavenPlugins for consistency.

Versions have been incremented to v0.3.0 accordingly.

Closes GH-78

@ascopes ascopes added documentation Improvements or additions to documentation enhancement labels Feb 3, 2024
@ascopes ascopes self-assigned this Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (025d2fd) 81.25% compared to head (91031b6) 81.61%.

Files Patch % Lines
...ufmavenplugin/dependency/BinaryPluginResolver.java 65.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   81.25%   81.61%   +0.35%     
==========================================
  Files          22       21       -1     
  Lines         635      631       -4     
  Branches       55       54       -1     
==========================================
- Hits          516      515       -1     
+ Misses         96       95       -1     
+ Partials       23       21       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ascopes ascopes merged commit 622e998 into main Feb 3, 2024
9 of 10 checks passed
@ascopes ascopes deleted the task/GH-78-remove-plugin branch February 3, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Plugin parameter type
1 participant