Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to download plugins and protoc from specified URLs #97

Merged
merged 5 commits into from
Feb 17, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Feb 17, 2024

This feature adds the ability to specify specific URLs (file://, http://, https://, ftp://, etc) to reference or download specific binaries for both protoc itself and any binary-based plugins.

This is not usually recommended, and is less secure than the other mechanisms, but is being added to allow the use of plugins that may only be distributed on sources such as GitHub, or on remote servers. It also allows users to reference a specific binary locally without adding it to the system path first, should this be needed.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (66bbf0d) 87.74% compared to head (846f60b) 84.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   87.74%   84.13%   -3.60%     
==========================================
  Files          22       23       +1     
  Lines         644      737      +93     
  Branches       51       53       +2     
==========================================
+ Hits          565      620      +55     
- Misses         57       92      +35     
- Partials       22       25       +3     
Files Coverage Δ
...tobufmavenplugin/dependency/JvmPluginResolver.java 87.04% <ø> (ø)
...bufmavenplugin/dependency/ResolutionException.java 100.00% <ø> (ø)
...tobufmavenplugin/generate/SourceCodeGenerator.java 98.44% <100.00%> (-0.04%) ⬇️
...tobufmavenplugin/source/ProtoArchiveExtractor.java 97.15% <100.00%> (ø)
...opes/protobufmavenplugin/AbstractGenerateMojo.java 62.50% <87.50%> (+2.86%) ⬆️
...ufmavenplugin/dependency/BinaryPluginResolver.java 85.37% <84.62%> (+3.55%) ⬆️
...s/protobufmavenplugin/generate/TemporarySpace.java 85.72% <33.34%> (-14.28%) ⬇️
...protobufmavenplugin/dependency/ProtocResolver.java 76.93% <69.24%> (-0.85%) ⬇️
...obufmavenplugin/dependency/UrlResourceFetcher.java 53.85% <53.85%> (ø)

@ascopes ascopes merged commit 6c15150 into main Feb 17, 2024
10 of 12 checks passed
@ascopes ascopes deleted the feature/url-plugins-and-protoc branch February 17, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant