Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kontent.ai CDN #19

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

ref-thomasledoux1
Copy link
Contributor

Added Kontent.ai CDN support.
Not sure how to run the tests locally, so couldn't verify this.

@ref-thomasledoux1
Copy link
Contributor Author

@ascorbic not sure if you get notified automatically, can't assign to you.

@ascorbic
Copy link
Owner

ascorbic commented Mar 6, 2023

Hey. Is there a way of ensuring that the API uses a "cover" cover strategy when resizing? This isn't giving the expected aspect ratio: https://assets-us-01.kc-usercontent.com/b744f382-bfc7-434d-93e7-a65d51249bc7/cc0afdc7-23d7-4fde-be2c-f58ad54d2934/daylight.jpg?w=800&h=300

@ascorbic
Copy link
Owner

ascorbic commented Mar 6, 2023

To run test tests locally you'll need the deno CLI installed, and then you can run deno test src

@ref-thomasledoux1
Copy link
Contributor Author

Hey @ascorbic I ran the tests locally now, should be passing now.
Also added a test for the "fit" behaviour.

@ascorbic
Copy link
Owner

ascorbic commented Mar 6, 2023

@ref-thomasledoux1
Copy link
Contributor Author

Ok, their docs weren’t really clear on this. Will adapt the logic.

@ascorbic
Copy link
Owner

ascorbic commented Mar 6, 2023

Yeah. I ended up just randomly trying values!

@ref-thomasledoux1
Copy link
Contributor Author

Updated the code + tests

Copy link
Owner

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for this.

@ascorbic ascorbic changed the title Adding kontent.ai CDN feat: add kontent.ai CDN Mar 6, 2023
@ascorbic ascorbic enabled auto-merge (squash) March 6, 2023 20:09
@ascorbic ascorbic merged commit 7475b58 into ascorbic:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants