-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch warnings for deprecations related to ASDF extensions #14444
Merged
WilliamJamieson
merged 1 commit into
astropy:main
from
WilliamJamieson:bugfix/deprecated_asdf_extension
Feb 22, 2023
Merged
Catch warnings for deprecations related to ASDF extensions #14444
WilliamJamieson
merged 1 commit into
astropy:main
from
WilliamJamieson:bugfix/deprecated_asdf_extension
Feb 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pllim
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Feb 22, 2023
… ASDF extensions
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Feb 22, 2023
… ASDF extensions
pllim
added a commit
that referenced
this pull request
Feb 23, 2023
…444-on-v5.2.x Backport PR #14444 on branch v5.2.x (Catch warnings for deprecations related to ASDF extensions)
pllim
added a commit
that referenced
this pull request
Feb 23, 2023
…444-on-v5.0.x Backport PR #14444 on branch v5.0.x (Catch warnings for deprecations related to ASDF extensions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-changelog-entry-needed
💤 backport-v5.0.x
on-merge: backport to v5.0.x
💤 backport-v5.2.x
on-merge: backport to v5.2.x
💤 io.misc.asdf
Go to asdf-astropy repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
asdf-format/asdf#1429 deprecated the ASDF extension types used. This PR catches those deprecations because
astropy.io.misc.asdf
is deprecated.Fixes #14443