Remove legacy extension api #1464

braingram · 2023-03-06T18:12:12Z

This PR removes the public api for the deprecated legacy extensions.

Internally, ASDF still uses this api for building and registering the BuiltinExtension so removal of the legacy extension methods and functions is not possible at this point.

Some objects were made private to prevent their inclusion in the documentation (AsdfType and AsdfExtension).

The asdf_extension entry point is preserved but modified to only load the BuiltinExtension. This modification means that many types previously converted by astropy.io.misc.asdf are now converted by asdf-astropy. This required updates to the test_version_map_support test to match the supported tags in asdf-astropy (and to make this test aware of the new extensions).

braingram · 2023-04-05T15:12:39Z

weldx downstream job failure for this PR looks like it should be fixed by weldx PR: BAMWelDX/weldx#863

CagtayFabry · 2023-04-05T15:28:24Z

weldx downstream job failure for this PR looks like it should be fixed by weldx PR: BAMWelDX/weldx#863

Yes we will release a new version soon based on the new extension API which should fix the downstream job

CagtayFabry · 2023-04-07T10:38:22Z

feel free to rerun the downstream welx test again now with weldx 0.6.5 @braingram

braingram · 2023-05-02T19:22:46Z

WeldX downstream failure related to new version of pint: BAMWelDX/weldx#872

eslavich

Just one silly thing of little consequence, LGTM either way.

Check out that ratio!

asdf/_types.py

eslavich · 2023-05-06T23:55:44Z

asdf/asdf.py

@@ -254,23 +252,6 @@ def extension_manager(self):
            self._extension_manager = get_cached_extension_manager(self._user_extensions + self._plugin_extensions)
        return self._extension_manager

-    @property


a few tests required updating as now several types are being converted by asdf-astropy instead of astropy.io.misc.asdf

for more information, see https://pre-commit.ci

braingram · 2023-05-08T13:36:04Z

FWIW: devdeps are failing on python 3.8 because gwcs has dropped python 3.8: spacetelescope/gwcs#451

pllim · 2023-05-09T00:50:32Z

This might have broken 2 of the astropy release branches: v5.2.x and v5.3.x

astropy v6.0.dev seems compatible but that is not going to be released until the end of 2023. Any chances this can be reverted and then wait 6 months? It is the v5.3.x that I worry about.

Example logs:

cc @WilliamJamieson

pllim · 2023-05-09T01:01:45Z

p.s. I opened astropy/astropy#14795

braingram · 2023-05-09T13:35:29Z

astropy v6.0.dev seems compatible but that is not going to be released until the end of 2023. Any chances this can be reverted and then wait 6 months? It is the v5.3.x that I worry about.

I would prefer to find a solution that does not revert and delay these changes for 6 months.

One option might be to install asdf-astropy and require it for building the docs on v5.3.x and v5.2.x (and update the documentation for the modeling example to describe that asdf-astropy is now required for saving astropy models to a file). Similar changes appear to have been included in astropy/astropy#14668

pllim · 2023-05-09T15:16:48Z

That would be too confusing for astropy users, as we have not removed deprecated code yet in those branches. I can always pin maxversion of asdf for those branches but I have a feeling that @nden won't like that.

pllim · 2023-05-09T15:17:19Z

Also, what is the rush of removing code here so much so soon?

braingram · 2023-05-09T15:30:28Z

That would be too confusing for astropy users, as we have not removed deprecated code yet in those branches. I can always pin maxversion of asdf for those branches but I have a feeling that @nden won't like that.

I must be missing something. How would adding a dependency for building the docs be confusing to an astropy user?

pllim · 2023-05-09T15:33:28Z

We are breaking the promise of requiring something that should not be required.

braingram · 2023-05-09T15:52:18Z

We are breaking the promise of requiring something that should not be required.

Serializing an astropy model with asdf 3.0 requires asdf-astropy. Are you proposing that asdf continue to support astropy.io.misc.asdf (which uses the deprecated asdf extension api) in asdf 3.0+? If so, how long would support for the deprecated extension api be required?

pllim · 2023-05-09T15:53:58Z

Didn't y'all write a whole long-term support policy a few months ago? I thought downstream would have another year, which wouldn't be a problem for us by then because astropy 6.0 should come out in 6 months.

pllim · 2023-05-09T15:54:50Z

It would be very easy for me to pin asdf<3 for astropy 5.x series, but it means STScI cannot use asdf 3 with stable astropy for another 6 months.

braingram · 2023-05-09T16:05:29Z

Didn't y'all write a whole long-term support policy a few months ago? I thought downstream would have another year, which wouldn't be a problem for us by then because astropy 6.0 should come out in 6 months.

It was agreed that ASDF does not have the resources to support formal LTS releases. Would committing to supporting 2.15 for 6 months meet your needs?

The currently released version of ASDF (2.15) should allow the doctest you linked to pass. However the run you linked installed the 3.0 development branch (main) of ASDF. This will continue to fail even if we can agree to support 2.15.

It would be very easy for me to pin asdf<3 for astropy 5.x series, but it means STScI cannot use asdf 3 with stable astropy for another 6 months.

Is that the solution you prefer?

pllim · 2023-05-09T16:09:15Z

Is that the solution you prefer?

If you cannot revert this, then that is what I must do. It is wrong to introduce breaking changes in v5.3.x after the freeze. We are already in RC.

Thanks for your inputs!

braingram added the development No backport required label Mar 6, 2023

github-actions bot added this to the 3.0.0 milestone Mar 6, 2023

braingram added the Downstream CI label Mar 6, 2023

braingram force-pushed the remove_legacy_extension_api branch 2 times, most recently from 0103147 to 0f1f1d7 Compare March 7, 2023 16:50

braingram marked this pull request as ready for review March 7, 2023 18:42

braingram requested a review from a team as a code owner March 7, 2023 18:42

braingram force-pushed the remove_legacy_extension_api branch from 8e0a6b9 to dab163d Compare March 10, 2023 14:38

braingram mentioned this pull request Mar 10, 2023

BUG: ignore io.misc.asdf tests for asdf >= 3.0.0.dev astropy/astropy#14516

Merged

braingram force-pushed the remove_legacy_extension_api branch from dab163d to 57e9ba5 Compare March 10, 2023 21:33

braingram mentioned this pull request Mar 16, 2023

Move built-in tags to converters (except ndarray and integer) #1474

Merged

braingram force-pushed the remove_legacy_extension_api branch from 57e9ba5 to 8529c69 Compare March 27, 2023 17:26

braingram force-pushed the remove_legacy_extension_api branch from 8529c69 to 0ddbd1e Compare April 5, 2023 14:21

braingram requested review from perrygreenfield and eslavich April 5, 2023 15:13

braingram force-pushed the remove_legacy_extension_api branch from 0ddbd1e to c4b71e5 Compare April 11, 2023 16:06

braingram force-pushed the remove_legacy_extension_api branch 2 times, most recently from a2d1aaf to 95ee7c0 Compare April 24, 2023 19:44

braingram mentioned this pull request Apr 27, 2023

drop depending on astropy.io.misc.asdf for test #1532

Merged

braingram force-pushed the remove_legacy_extension_api branch 2 times, most recently from 48ab7a7 to d58a895 Compare May 2, 2023 18:58

eslavich approved these changes May 7, 2023

View reviewed changes

braingram added 4 commits May 8, 2023 09:19

disable asdf_extension entry point

3f619a5

a few tests required updating as now several types are being converted by asdf-astropy instead of astropy.io.misc.asdf

remove top level legacy extension deprecated modules

76b28e5

removed deprecated asdf.extension legacy api objects and functions

6db1667

remove legacy extension api deprecated AsdfFile methods/attrs

710a61e

braingram and others added 9 commits May 8, 2023 09:19

update changes

61727f9

remove asdf.CustomType, cleanup docs

057d3b9

make AsdfType private

6c059c3

make AsdfExtension private

803fd95

remove commented lines in docs

4b4de3b

remove more AsdfExtension references

37919ec

remove resolver ref

296599c

[pre-commit.ci] auto fixes from pre-commit.com hooks

a5da3bf

for more information, see https://pre-commit.ci

remove _AsdfType from __all__

19dc360

braingram force-pushed the remove_legacy_extension_api branch from 5437d52 to 19dc360 Compare May 8, 2023 13:19

braingram merged commit 587542e into asdf-format:main May 8, 2023

braingram deleted the remove_legacy_extension_api branch May 8, 2023 13:52

pllim mentioned this pull request May 9, 2023

TST: asdf 3.0.0.dev cannot represent Rotation2D (v5.0.x, v5.2.x, v5.3.x) astropy/astropy#14795

Closed

pllim mentioned this pull request May 9, 2023

MNT: Pin asdf<3 in LTS astropy/astropy#14796

Closed

braingram mentioned this pull request May 9, 2023

Revert "Remove legacy extension api" #1544

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove legacy extension api #1464

Remove legacy extension api #1464

braingram commented Mar 6, 2023 •

edited

Loading

braingram commented Apr 5, 2023 •

edited

Loading

CagtayFabry commented Apr 5, 2023

CagtayFabry commented Apr 7, 2023

braingram commented May 2, 2023

eslavich left a comment

eslavich May 6, 2023

braingram commented May 8, 2023

pllim commented May 9, 2023

pllim commented May 9, 2023

braingram commented May 9, 2023

pllim commented May 9, 2023

pllim commented May 9, 2023

braingram commented May 9, 2023

pllim commented May 9, 2023

braingram commented May 9, 2023

pllim commented May 9, 2023

pllim commented May 9, 2023

braingram commented May 9, 2023

pllim commented May 9, 2023

Remove legacy extension api #1464

Remove legacy extension api #1464

Conversation

braingram commented Mar 6, 2023 • edited Loading

braingram commented Apr 5, 2023 • edited Loading

CagtayFabry commented Apr 5, 2023

CagtayFabry commented Apr 7, 2023

braingram commented May 2, 2023

eslavich left a comment

Choose a reason for hiding this comment

eslavich May 6, 2023

Choose a reason for hiding this comment

braingram commented May 8, 2023

pllim commented May 9, 2023

pllim commented May 9, 2023

braingram commented May 9, 2023

pllim commented May 9, 2023

pllim commented May 9, 2023

braingram commented May 9, 2023

pllim commented May 9, 2023

braingram commented May 9, 2023

pllim commented May 9, 2023

pllim commented May 9, 2023

braingram commented May 9, 2023

pllim commented May 9, 2023

braingram commented Mar 6, 2023 •

edited

Loading

braingram commented Apr 5, 2023 •

edited

Loading