Force user to provide a version when uninstall #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hugo-tubi. Thanks for adding this PR. After stumbling upon the same issue, I'd be happy if I'd known this before. Eventually, this - or your PR - helped me #266 (comment). I'm looking forward to seeing this PR get merged. |
Stratus3D
approved these changes
May 19, 2023
|
Thanks for the PR @hugo-tubi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #266, if user type
asdf uninstall erlangwithout a version, the kerl installation state will be break. The packages will be removed (i.e. the directory~/.asdf/installs/erlang/will be empty. However a re-installation on the same version will not work (unless manually touch files like~.asdf/plugins/erlang/kerl-home/otp_installation.This PR can prevent that situation. Other options may also possible, please guide me if we want go other options.
P.S I didn't add validation on version provided, since if the user type a
asdf uninstall erlang <version-non-exists>, adsf would tell and refuse to continue, which is cool!